From: Marco Trevisan (Treviño) <mail@3v1n0.net>
Date: Tue, 30 Jun 2026 19:32:12 +0000 (+0200)
Subject: extensionSystem: Clarify what the extension disable function does
X-Git-Tag: archive/raspbian/50.5-1+rpi1^2~9^2^2~22
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=d9070835c51c0697e4d3ffdeaba09ce39323f674;p=gnome-shell.git

extensionSystem: Clarify what the extension disable function does

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/4276>
(cherry picked from commit f10dcaac409ea87c1577e7df4fccdf16a3768597)
---

diff --git a/js/ui/extensionSystem.js b/js/ui/extensionSystem.js
index 8a10c5c5b..fcff08eb4 100644
--- a/js/ui/extensionSystem.js
+++ b/js/ui/extensionSystem.js
@@ -115,7 +115,7 @@ export class ExtensionManager extends Signals.EventEmitter {
                 this._unloadExtensionStylesheet(ext);
                 this._loadExtensionStylesheet(ext);
             } catch (e) {
-                this._callExtensionDisable(ext.uuid);
+                this._callExtensionDisableWithRebase(ext.uuid);
                 this.logExtensionError(ext.uuid, e);
             }
         }
@@ -180,7 +180,7 @@ export class ExtensionManager extends Signals.EventEmitter {
         return false;
     }
 
-    async _callExtensionDisable(uuid) {
+    async _callExtensionDisableWithRebase(uuid) {
         const extension = this.lookup(uuid);
         if (!extension)
             return;
@@ -448,7 +448,7 @@ export class ExtensionManager extends Signals.EventEmitter {
         // Try to disable it -- if it's ERROR'd, we can't guarantee that,
         // but it will be removed on next reboot, and hopefully nothing
         // broke too much.
-        await this._callExtensionDisable(uuid);
+        await this._callExtensionDisableWithRebase(uuid);
 
         this._changeExtensionState(extension, ExtensionState.UNINSTALLED);
 
@@ -580,7 +580,7 @@ export class ExtensionManager extends Signals.EventEmitter {
 
         for (const uuid of extensionsToDisable) {
             // eslint-disable-next-line no-await-in-loop
-            await this._callExtensionDisable(uuid);
+            await this._callExtensionDisableWithRebase(uuid);
         }
 
         // Find and enable all the newly enabled extensions: UUIDs found in the
@@ -775,7 +775,7 @@ export class ExtensionManager extends Signals.EventEmitter {
 
         for (const uuid of extensionsToDisable) {
             // eslint-disable-next-line no-await-in-loop
-            await this._callExtensionDisable(uuid);
+            await this._callExtensionDisableWithRebase(uuid);
         }
     }